Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Staking misc rename #3314

Merged
merged 7 commits into from
Jan 17, 2019
Merged

R4R: Staking misc rename #3314

merged 7 commits into from
Jan 17, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jan 17, 2019 •
edited
Loading

closes #3289

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski added C:x/staking ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #3314 into develop will decrease coverage by 0.03%.
The diff coverage is 92.59%.

@@             Coverage Diff             @@
##           develop    #3314      +/-   ##
===========================================
- Coverage     55.6%   55.57%   -0.04%     
===========================================
  Files          132      132              
  Lines         9540     9528      -12     
===========================================
- Hits          5305     5295      -10     
+ Misses        3900     3898       -2     
  Partials       335      335

alessio
alessio approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor command, definitely not a blocker.

x/staking/types/msg.go Outdated Show resolved Hide resolved
cwgoes
cwgoes approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK (also ran make format), I second @alessio's comment.

@cwgoes cwgoes merged commit 8f7a222 into develop Jan 17, 2019
@cwgoes cwgoes deleted the rigel/staking-misc-rename branch January 17, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alessio alessio alessio approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
C:x/staking T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staking renaming
3 participants
@rigelrozanski @alessio @cwgoes